Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use dependency-groups #873

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 27, 2024

As a side affect of using dependency-groups, uv run pytest works out of the box! I've split the test requirements into test and dev.

Also, the old dev requirements was including the conda-test file, which is actually a list of conda packages, not a PyPI list.

I've also modernized a few other things, like using default=, the python versions are read from the classifiers, author list fixed, and pypy3.9 is no longer supported by upstream.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Collaborator Author

@theacodes, @dhermes, @cjolowicz, or @DiddiLeija, could one of you enable PR builds on readthedocs? I've modernized the readthedocs config, should be much faster, but I'd like to see if it builds correctly in the PR.

@theacodes
Copy link
Collaborator

@henryiii done!

@henryiii henryiii closed this Oct 28, 2024
@henryiii henryiii reopened this Oct 28, 2024
@henryiii
Copy link
Collaborator Author

There still seems to be something missing, like a webhook. Could you re-sync the webhook, perhaps?

https://docs.readthedocs.io/en/stable/guides/pull-requests.html

@theacodes
Copy link
Collaborator

Alright, I resynced the webhook. Give it another shot?

@henryiii henryiii closed this Oct 28, 2024
@henryiii henryiii reopened this Oct 28, 2024
@henryiii
Copy link
Collaborator Author

That got it, thanks!

@henryiii
Copy link
Collaborator Author

Cuts the docs time to less than half of that it was before. :)

@henryiii henryiii marked this pull request as ready for review October 28, 2024 16:36
@theacodes
Copy link
Collaborator

Rad! This looks good to me, then. :)

@henryiii henryiii merged commit 7dd02a8 into wntrblm:main Oct 28, 2024
70 checks passed
@henryiii henryiii deleted the henryiii/chore/dependency-groups branch October 28, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants