-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add micromamba support #807
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,7 +236,7 @@ class CondaEnv(ProcessEnv): | |
""" | ||
|
||
is_sandboxed = True | ||
allowed_globals = ("conda", "mamba") | ||
allowed_globals = ("conda", "mamba", "micromamba") | ||
|
||
def __init__( | ||
self, | ||
|
@@ -305,6 +305,12 @@ def create(self) -> bool: | |
return False | ||
|
||
cmd = [self.conda_cmd, "create", "--yes", "--prefix", self.location] | ||
if self.conda_cmd == "micromamba" and not any( | ||
v.startswith(("--channel=", "-c")) or v == "--channel" | ||
for v in self.venv_params | ||
): | ||
# Micromamba doesn't have any default channels | ||
cmd.append("--channel=conda-forge") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might be worth mentioning this default in the docs as it is not quite the same as relying on PyPI (which doesn't re-package software from 3rd party authors as conda-forge does). Linking to the conda-forge security considerations would be even better to inform users about that. |
||
|
||
cmd.extend(self.venv_params) | ||
|
||
|
@@ -314,7 +320,9 @@ def create(self) -> bool: | |
python_dep = f"python={self.interpreter}" if self.interpreter else "python" | ||
cmd.append(python_dep) | ||
|
||
logger.info(f"Creating conda env in {self.location_name} with {python_dep}") | ||
logger.info( | ||
f"Creating {self.conda_cmd} env in {self.location_name} with {python_dep}" | ||
) | ||
nox.command.run(cmd, silent=True, log=nox.options.verbose or False) | ||
|
||
return True | ||
|
@@ -589,6 +597,7 @@ def venv_backend(self) -> str: | |
ALL_VENVS: dict[str, Callable[..., ProcessEnv]] = { | ||
"conda": functools.partial(CondaEnv, conda_cmd="conda"), | ||
"mamba": functools.partial(CondaEnv, conda_cmd="mamba"), | ||
"micromamba": functools.partial(CondaEnv, conda_cmd="micromamba"), | ||
"virtualenv": functools.partial(VirtualEnv, venv_backend="virtualenv"), | ||
"venv": functools.partial(VirtualEnv, venv_backend="venv"), | ||
"uv": functools.partial(VirtualEnv, venv_backend="uv"), | ||
|
@@ -601,5 +610,6 @@ def venv_backend(self) -> str: | |
OPTIONAL_VENVS = { | ||
"conda": shutil.which("conda") is not None, | ||
"mamba": shutil.which("mamba") is not None, | ||
"micromamba": shutil.which("micromamba") is not None, | ||
"uv": HAS_UV, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henryiii This sounds ominous, Anaconda's
defaults
channel is commercially licensed and is free to use for educational users and companies with fewer than 200 employees.