Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum virtualenv to 20.14.1 #747

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Bump minimum virtualenv to 20.14.1 #747

merged 1 commit into from
Feb 20, 2024

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented Nov 12, 2023

virtualenv dependencies, for example

can cause dependency resolution of virtualenv to drop to an older version (for example 20.4.7) that can cause nox to fail due to using deprecated setuptools behavior. For example:

Bump nox's minimum virtualenv version to avoid dependency resolution selecting a very outdated virtualenv, which isn't tested and can fail.

virtualenv 20.14.1 was released 2022-04-11.

@henryiii
Copy link
Collaborator

There are also some workaround in the codebase that could be dropped by increasing the min virtualenv version. Like

nox/nox/virtualenv.py

Lines 353 to 355 in 5c82dc5

if not os.path.isfile(path):
# virtualenv < 20.0 does not create pyvenv.cfg
old_env = "virtualenv"

@theacodes theacodes merged commit a6cfa2e into wntrblm:main Feb 20, 2024
21 checks passed
@johnthagen johnthagen deleted the update-minimum-virtualenv branch February 20, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants