Fixed Improper Method Call: Replaced NotImplementedError (#749)

* Replaced `NotImplementedError` with `NotImplemented` Signed-off-by: fazledyn-or <[email protected]> * Fix tests for #749 --------- Signed-off-by: fazledyn-or <[email protected]> Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
wntrblm · Feb 20, 2024 · f8df3c1 · f8df3c1
1 parent 4f73b76
commit f8df3c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/nox/_parametrize.py b/nox/_parametrize.py
@@ -78,7 +78,7 @@ def __eq__(self, other: object) -> bool:
         elif isinstance(other, dict):
             return dict(zip(self.arg_names, self.args)) == other
 
-        raise NotImplementedError
+        return NotImplemented
 
 
 def _apply_param_specs(param_specs: Iterable[Param], f: Any) -> Any:

diff --git a/tests/test__parametrize.py b/tests/test__parametrize.py
@@ -35,8 +35,7 @@ def test_param_eq(param, other, expected):
 
 
 def test_param_eq_fail():
-    with pytest.raises(NotImplementedError):
-        _parametrize.Param() == "a"  # noqa: B015
+    assert _parametrize.Param() != "a"
 
 
 def test_parametrize_decorator_one():