feat: throw an error if an infused transaction is a no-op

wnfs-wg · Dec 15, 2023 · a21de2a · a21de2a
1 parent e1fda8d
commit a21de2a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/nest/readme.md b/packages/nest/readme.md
@@ -110,6 +110,8 @@ const fs = FileSystem.create({
 })
 ```
 
+When you make a modification through the `transaction` method and the commit ends up not being approved, this will result in a `"no-op"` string. In the case of using a regular mutation method such as `write` it will produce an error.
+
 ## Docs
 
 Check <https://fission-codes.github.io/stack>

diff --git a/packages/nest/src/class.ts b/packages/nest/src/class.ts
@@ -699,11 +699,13 @@ export class FileSystem {
   ): Promise<MutationResult<Partition>> {
     const transactionResult = await this.transaction(handler, mutationOptions)
 
-    const dataRoot =
-      transactionResult === 'no-op'
-        ? await this.calculateDataRoot()
-        : transactionResult.dataRoot
+    if (transactionResult === 'no-op') {
+      throw new Error(
+        'The transaction was a no-op, most likely as a result of the commit not being approved by the `onCommit` verifier.'
+      )
+    }
 
+    const dataRoot = transactionResult.dataRoot
     const partition = determinePartition(path)
 
     switch (partition.name) {