fix: mc fails on uploading large files to gcs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
force-pushed
the
fr/gsutil
branch
3 times, most recently
from
63f7aca
to
33467a6
Compare
m90
force-pushed
the
fr/gsutil
branch
5 times, most recently
from
917bd55
to
314343b
Compare
m90
commented
Aug 16, 2023
| mc cp --recursive /backups/output/ remote/"$STORAGE_BUCKET_NAME" | ||
| AWS_ACCESS_KEY_ID=$STORAGE_ACCESS_KEY \ | ||
| AWS_SECRET_ACCESS_KEY=$STORAGE_SECRET_KEY \ | ||
| AWS_DEFAULT_REGION=us-east-1 \ |
There was a problem hiding this comment.
This is here so that boto does not bail. It does not have any effect.
m90
commented
Aug 16, 2023
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
| mc alias set remote "$STORAGE_ENDPOINT" "$STORAGE_ACCESS_KEY" "$STORAGE_SECRET_KEY" --api "$STORAGE_SIGNATURE_VERSION" | |||
| mc cp --recursive /backups/output/ remote/"$STORAGE_BUCKET_NAME" | |||
| AWS_ACCESS_KEY_ID=$STORAGE_ACCESS_KEY \ | |||
There was a problem hiding this comment.
This mapping of env vars is here so that:
a. we don't need chart changes
b. people could get confused about how we now need AWS credentials
deer-wmde
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcfails uploading larger files (> 12GB) to GCS. This PR moves the upload to use AWS CLI instead.AWS CLI is Apache-2.0 licensed, so packaging it here shall be fine.