feat: upload file using an s3 client #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
force-pushed
the
fr/client-copy
branch
10 times, most recently
from
6603e9c
to
fe60e76
Compare
m90
commented
Aug 9, 2023
Dockerfile
Outdated
| && apt-get install --yes gcsfuse=0.40.0 --no-install-recommends \ | ||
| && apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
| mariadb-client=1:10.1.48-0ubuntu0.18.04.1 && \ | ||
| curl https://dl.min.io/client/mc/release/linux-amd64/mc \ |
There was a problem hiding this comment.
This should still be locked down to a specific version.
|
Chart update here wbstack/charts#125 |
m90
commented
Aug 10, 2023
| else | ||
| echo "Skip uploading..." | ||
| echo "Skipping upload as DO_UPLOAD is not set..." |
There was a problem hiding this comment.
We could also remove this option now as we can also "upload" in local environments.
deer-wmde
reviewed
Aug 14, 2023
src/upload.sh
Outdated
|
|
||
| set -e | ||
| mc alias set remote "$STORAGE_ENDPOINT" "$STORAGE_ACCESS_KEY" "$STORAGE_SECRET_KEY" --api "$STORAGE_SIGNATURE_VERSION" | ||
| mc cp --recursive /backups/output remote/"$STORAGE_BUCKET_NAME" |
There was a problem hiding this comment.
Suggested change
| mc cp --recursive /backups/output remote/"$STORAGE_BUCKET_NAME" | |
| mc cp --recursive /backups/output/ remote/"$STORAGE_BUCKET_NAME" |
This way (with the trailing / for the source directory) it does not create a output folder in the bucket which mimics the current behaviour
There was a problem hiding this comment.
Oh, this is a nice find. Thanks. Will also update the test case then.
deer-wmde
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T343112