Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed stencil from shadow rendering #61

Merged
merged 4 commits into from
Sep 18, 2024
Merged

feat: removed stencil from shadow rendering #61

merged 4 commits into from
Sep 18, 2024

Conversation

WillPower3309
Copy link
Member

No description provided.

@WillPower3309
Copy link
Member Author

Shadow portion of #62

@WillPower3309
Copy link
Member Author

WillPower3309 commented Sep 18, 2024 •
edited
Loading

Hmm, strangely enough it seems that there is a small gap between the windows corner (when rounded) and the shadows corner, which is strange since we'd use the same roundRectSDF function 🤔

Edit: fixed, bad logic on my part

ErikReider
ErikReider requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM! The improvement really is noticable :D

render/fx_renderer/fx_pass.c Outdated Show resolved Hide resolved
@ErikReider ErikReider merged commit 9b30e2d into main Sep 18, 2024
@ErikReider ErikReider deleted the no_stencil_shadows branch September 18, 2024 10:38
@ErikReider ErikReider mentioned this pull request Sep 18, 2024
Merged
@WillPower3309 WillPower3309 mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikReider ErikReider ErikReider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillPower3309 @ErikReider