Use PyMapping_GetOptionalItemString where necessary with Python 3.13 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python 3.13, some lookup methods like `PyMapping_GetItemString` and `PyObject_GetAttrString` became more strict. They are now always throwing an exception in case the attribute is not found. To make these optional lookups work again, the `GetOptional` family of functions needs to be used. See: * https://docs.python.org/3/c-api/object.html#c.PyObject_GetOptionalAttrString * https://docs.python.org/3/c-api/mapping.html#c.PyMapping_GetOptionalItemString This is the upstream version of the following ROOT commit: * root-project/root@e78450dc45ed868b7a52a0
|
Interesting, since even with py13, wlav/cppyy#273 doesn't fail for me. |
|
Yes, I've read that. Maybe my reproducer in the issue is not complete. I'll investigate this further. |
|
As for the PR, I'm much rather use a more descriptive name and put a compatibility function in This graph shows that py3.7 is the oldest I need to care about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python 3.13, some lookup methods like
PyMapping_GetItemStringandPyObject_GetAttrStringbecame more strict. They are now always throwing an exception in case the attribute is not found.To make these optional lookups work again, the
GetOptionalfamily of functions needs to be used.See:
This is the upstream version of the following ROOT commit:
Related to the following cppyy issue, although it might be better to close that issue by fixing the underlying problem: