add config option for an authorization file #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case the credentials should be loaded from an external file My particular use case is that I want to version control the .cfg file, but I don't want to put my username/password in the file
Mostly in regards to unicode string handling. Ldap search results returns "keys" in utf-8, but values are often in bytes. stringify values after querying so that results and cache aren't treated differently. Open files in text mode instead of binary mode. SafeConfigParser was renamed to ConfigParser in python3. LOG.warn is deprecated, change to "LOG.warning" to avoid deprecation output messages.
... such as pass from the passwordstore
allow setting password by passing command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case the credentials should be loaded from an external file
My particular use case is that I want to version control the .cfg
file, but I don't want to put my username/password in the file