-
Notifications
You must be signed in to change notification settings - Fork 264
completely disable the use of selenium wire #275
base: master
Are you sure you want to change the base?
Conversation
Many thanks for the PR! Yes having an option to disable Selenium Wire programmatically sounds like it could be useful. I've made a couple of comments and would be happy to merge if you're able to resolve. |
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 86.04% 85.08% -0.96%
==========================================
Files 13 13
Lines 1096 1120 +24
==========================================
+ Hits 943 953 +10
- Misses 153 167 +14
Continue to review full report at Codecov.
|
Thanks for making the changes - all looks good. I've just run the code with undetected chromedriver and realized that we're going to need to wait for your other PR to get merged first, otherwise undetected chromedriver will raise:
So once that undetected chromedriver PR is merged we're good to merge this one. Thanks again! |
okay, thanks |
close #274