Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alexadominguez--practice2 #38

Open
wants to merge 5 commits into
base: practice-day4
Choose a base branch
from
Open

alexadominguez--practice2 #38

wants to merge 5 commits into from

Conversation

aledomsa
Copy link

@aledomsa aledomsa commented Jan 17, 2022 •
edited
Loading

  • Created archiver file.
  • Added archiver class from implementation given.
  • Removed requires and initialize. Added testing_text for testing.
  • Removed data variable in read_file method and self.
  • Added testing code.

@aledomsa
Copy link
Author

@Apostat23

lscantillowl
lscantillowl reviewed Jan 17, 2022
View reviewed changes
testing_text.txt
@@ -0,0 +1,3 @@
Hi I´m Alexa but not from Amazon.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lscantillowl hahaha now it is my personal jk

lscantillowl
lscantillowl reviewed Jan 17, 2022
View reviewed changes
archiver.rb

@@modes.each do |mode|
define_method("open_file_as_#{mode}") do |file|
@file = File.open(file, "r") if mode == :reader
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer use "" for interpolations. If you use just string ''

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I will change this.

lscantillowl
lscantillowl reviewed Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@lscantillowl lscantillowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lscantillowl lscantillowl lscantillowl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aledomsa @lscantillowl