damian-moreno--practice-day5 #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apostat23
reviewed
Jan 13, 2022
| attr_accessor :missions | ||
|
|
||
| @@mission_status = %w(active paused aborted accomplished failed) | ||
|
|
There was a problem hiding this comment.
I would avoid this extra empty line here as @@mission_status is set and used right after.
Apostat23
reviewed
Jan 13, 2022
| } | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
An extra empty line at the end of the file is needed and taken as a good practice.
Apostat23
reviewed
Jan 13, 2022
| players: {}, | ||
| control: {}, | ||
| status: nil | ||
| } |
There was a problem hiding this comment.
I would define this kind of hashes using one line @board = { players: {}, control: {}, status: nil }
Apostat23
reviewed
Jan 13, 2022
|
|
||
| x = ErrorTest.new | ||
| x.new_worker name: 'damian' | ||
| x.new_mission(pack: {}) |
There was a problem hiding this comment.
Same thing, please add an extra empty line at the end of the files.
Apostat23
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! just a quick note: rubocop keep telling me that the error handling-blocks where 'redundant' i think for the sake of this exercise was necessary since I needed to raise the errors and catch them on the same block, wich i agree is redundant.
I personally always have issues locating where to raise/catch errors and this practice just confused me more. @jakobhans @hivanreyes @Apostat23