josechavez--practice5 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apostat23
reviewed
Jan 13, 2022
environment.rb
Outdated
| @@ -0,0 +1,101 @@ | |||
| module Environment | |||
| class Depot | |||
There was a problem hiding this comment.
Indentation should be two spaces, be careful when setting the TAB range in your IDE, sometimes Git just ignore the setting and take a tab as a 4-spaces-TAB.
Apostat23
reviewed
Jan 13, 2022
environment.rb
Outdated
| objective: objective, | ||
| status: :active, | ||
| pack: pack | ||
| } |
There was a problem hiding this comment.
I would state hashes like this in one line if possible.
@missions[name] = { objective: objective, status: :active, pack: pack }
Apostat23
reviewed
Jan 13, 2022
environment.rb
Outdated
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
An extra empty line at the end of the file would be great. It is taken as a good practice.
Apostat23
reviewed
Jan 13, 2022
error_test.rb
Outdated
| # name = :alpha; objective = 'Get Alpha to the base'; pack = :simple_transportation_pack | ||
| # error_test.new_mission(name: name, objective: objective, pack: error_test.depot.packs[pack]) | ||
| # puts error_test.control.missions[:alpha] | ||
| # error_test.control.set_mission_to_accomplished(:alpha) and puts error_test.control.missions[:alpha] |
There was a problem hiding this comment.
Same thing here, I would try to use an extra empty line at the end of the file.
Apostat23
reviewed
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error methods added with the next results:
new_worker name: error
new_mission name: error
new_mission objetive: error
new_mission pack: error
