ErickGodoy--Practice2 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| attr_accessor :file | ||
| @modes = %i[reader writer both] | ||
|
|
||
| def initialize |
There was a problem hiding this comment.
You could delete the empty constructor def initialize with any issue
There was a problem hiding this comment.
it can be also initializated like def initialize; end.
| end | ||
|
|
||
| def create_file(path_file) | ||
| File.new(path_file,'w') if !File.exist?(path_file) |
There was a problem hiding this comment.
Use unless over if with negatives conditions. File.new(path_file,'w') unless File.exist?(path_file)
| end | ||
|
|
||
| def read_file(lines: false) | ||
| lines ? data = self.file&.read : data = self.file&.readlines.map(&:chomp) |
There was a problem hiding this comment.
It is not necessary to declare the function data, just need self.file&.read
| end | ||
|
|
||
| def write_file(data: nil, append: true) | ||
| append ? File.write(self.file, data, mode: "a") : File.write(self.file, data) |
There was a problem hiding this comment.
Within this scope you could remove self statement
Apostat23
reviewed
Jan 13, 2022
| archiver.create_file('test.txt') | ||
| archiver.open_file_as_both('test.txt') | ||
| archiver.write_file(data: 'Put this into a file each time.', append: true) | ||
| p archiver.read_file |
There was a problem hiding this comment.
An extra empty line at the end of the file is taken as a good practice.
Apostat23
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.