aldo-leon--practice3 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment module added Game class added
environment.rb
Outdated
| end | ||
|
|
||
| class Control | ||
| mission_status = [:paused, :aborted, :failed, :accomplished] |
There was a problem hiding this comment.
Use %i syntaxis. %i[paused aborted failed accomplished]
environment.rb
Outdated
| class Worker < Human | ||
| attr_accessor :standard_shift, :extra_shift | ||
| def set_shift | ||
| @standard_shift ={ |
There was a problem hiding this comment.
Try to do this
@standard_shift = {
id: self.object_id,
hours: 8,
payment: 8,
facility: String.new,
status: nil
}
There was a problem hiding this comment.
...or this:
@standard_shift = { id: self.object_id, hours: 8, payment: 8, facility: '', status: nil }
Apostat23
reviewed
Jan 13, 2022
| attr_accessor :missions | ||
| def initialize | ||
| @missions = {} | ||
| end |
There was a problem hiding this comment.
To use an empty line among method definitions would be great.
Apostat23
reviewed
Jan 13, 2022
game.rb
Outdated
|
|
||
| def new_mission(name: nil, objective: nil, pack: nil) | ||
| @control.new_mission(name: name, objective: objective, pack: pack) | ||
| @board[:control][:missions] = @control.missions |
There was a problem hiding this comment.
Indentation should be only two spaces.
Apostat23
reviewed
Jan 13, 2022
| name = :alpha; objective = 'Get Alpha to the base'; pack = :simple_transportation_pack | ||
| game.new_mission name: name, objective: objective, pack: game.depot.packs[pack] | ||
| puts game.control.missions[:alpha] | ||
| game.control.set_mission_to_accomplished(:alpha) and puts game.control.missions[:alpha] |
There was a problem hiding this comment.
To use an extra empty line at the bottom of the file is taken as a good practice.
Apostat23
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙂 @Apostat23 @hivanreyes @Rikard189
Output:
