First delivery #70
Open
First delivery #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-adjustments Add Wizeline Academy Slack invitation link
timgivois
reviewed
Jul 10, 2018
.env
Outdated
| @@ -0,0 +1,3 @@ | |||
| REACT_APP_API_URL = https://api.giphy.com | |||
There was a problem hiding this comment.
umm don't know why this is still here
timgivois
reviewed
Jul 10, 2018
| class FavsContainer extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = {}; |
There was a problem hiding this comment.
if you aren't using this you can delete it :)
timgivois
reviewed
Jul 10, 2018
| import React, { Component } from "react"; | ||
| import styled from "styled-components"; | ||
|
|
||
| const StyledImg = styled.div` |
There was a problem hiding this comment.
you can create a styled.img instead of a div with an img inside
timgivois
reviewed
Jul 10, 2018
| ? selectedFavs.indexOf(giphy.id) !== -1 | ||
| : false; | ||
|
|
||
| if (isFav) { |
There was a problem hiding this comment.
you can create one styled component that receive a prop isFav and then you add border if isFav if not you don't do anything.
StyledImg = styled.img`
${props => props.isFav && `
border: 1em solid red;
border-radius: 1em;
`}
`
timgivois
reviewed
Jul 10, 2018
| import styled from "styled-components"; | ||
| import { Link } from "react-router-dom"; | ||
|
|
||
| const StyledMenu = styled.div` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an API Key is needed at the .env file, REACT_APP_GIPHY_API_KEY =