wp:implementación del challenge #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 7, 2018 00:30
bgilm
reviewed
Jul 10, 2018
| <Switch> | ||
| <Route exact path="/" component={ ContainerListGiphy } /> | ||
| <Route path="/favorites" component={ ContainerGiphysFavorites } /> | ||
| <Route path='*' component={NotFound} /> |
There was a problem hiding this comment.
Not necessary to specify a path, if you live the path empty it will always match, and because the Route is at the end of the switch it will work as expected.
timgivois
reviewed
Jul 11, 2018
| import {BrowserRouter, Switch, Route} from "react-router-dom"; | ||
| import ContainerListGiphy from './giphy/container/container-list-giphy'; | ||
| import ContainerGiphysFavorites from './giphy-favorite/container/container-giphys-favorites'; | ||
| import NotFound from './giphy/components/not-found'; | ||
| import './App.css'; |
There was a problem hiding this comment.
Use styled components instead of global css
timgivois
reviewed
Jul 11, 2018
| export default function ListGiphy(props){ | ||
| return( | ||
| <React.Fragment> | ||
| <div className="container-giphy" onClick={props.handleOpenModal}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.