-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request - Francisco Rafael Arce García #58
Open
fragmnt02
wants to merge
29
commits into
wizelineacademy:master
Choose a base branch
from
fragmnt02:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b7c75d4
iniciando proyecto, instalando router y creando componentes
fragmnt02 24e3a9b
agregando search
fragmnt02 8f263e8
agregando logica search
fragmnt02 c74cd07
modificiacaion
fragmnt02 156cd04
redux with errors
fragmnt02 6057123
trending and search with redux and sagas
fragmnt02 7ead9e1
Search and home works properly
fragmnt02 54dc0e6
Adding env to .gitignore
fragmnt02 696fecd
logica terminada
fragmnt02 28628ee
fav working correctly
fragmnt02 edaee3c
remove fav
fragmnt02 69f40eb
Details
fragmnt02 841e975
deleting unused libraries
fragmnt02 efcace5
gif button change fixed
fragmnt02 9d7731d
gifs heart button working
fragmnt02 20bbf29
feedback corrections
fragmnt02 004dd63
remove state from fav page
fragmnt02 f78658d
favpage error fixed
fragmnt02 1ab462d
some tests
fragmnt02 fbfe216
fix some errors
fragmnt02 50ecfa1
only working test
fragmnt02 70e030c
some changes
fragmnt02 b38b715
gif test
fragmnt02 84badf9
fav reducer test fixed
fragmnt02 5590345
saga test
fragmnt02 43499c4
sagas tests
fragmnt02 fbdfbc7
sagas
fragmnt02 98211ac
unused state
fragmnt02 ccf7d6d
fix
fragmnt02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| REACT_APP_API_KEY=iSAbLNTnHlhG33VP27yEQDITzhxAZ1iZ | ||
| REACT_APP_TIMEOUT=15000 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend that you add this file to your .gitignore as this are api keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thnks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thnks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You pushed it? I can still see your .env config