Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request - Francisco Rafael Arce García #58

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Pull Request - Francisco Rafael Arce García #58

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b7c75d4
iniciando proyecto, instalando router y creando componentes
fragmnt02 Jul 5, 2018
24e3a9b
agregando search
fragmnt02 Jul 6, 2018
8f263e8
agregando logica search
fragmnt02 Jul 6, 2018
c74cd07
modificiacaion
fragmnt02 Jul 7, 2018
156cd04
redux with errors
fragmnt02 Jul 8, 2018
6057123
trending and search with redux and sagas
fragmnt02 Jul 9, 2018
7ead9e1
Search and home works properly
fragmnt02 Jul 9, 2018
54dc0e6
Adding env to .gitignore
fragmnt02 Jul 9, 2018
696fecd
logica terminada
fragmnt02 Jul 9, 2018
28628ee
fav working correctly
fragmnt02 Jul 9, 2018
edaee3c
remove fav
fragmnt02 Jul 9, 2018
69f40eb
Details
fragmnt02 Jul 9, 2018
841e975
deleting unused libraries
fragmnt02 Jul 9, 2018
efcace5
gif button change fixed
fragmnt02 Jul 10, 2018
9d7731d
gifs heart button working
fragmnt02 Jul 10, 2018
20bbf29
feedback corrections
fragmnt02 Jul 10, 2018
004dd63
remove state from fav page
fragmnt02 Jul 10, 2018
f78658d
favpage error fixed
fragmnt02 Jul 11, 2018
1ab462d
some tests
fragmnt02 Jul 11, 2018
fbfe216
fix some errors
fragmnt02 Jul 11, 2018
50ecfa1
only working test
fragmnt02 Jul 11, 2018
70e030c
some changes
fragmnt02 Jul 12, 2018
b38b715
gif test
fragmnt02 Jul 12, 2018
84badf9
fav reducer test fixed
fragmnt02 Jul 12, 2018
5590345
saga test
fragmnt02 Jul 12, 2018
43499c4
sagas tests
fragmnt02 Jul 12, 2018
fbdfbc7
sagas
fragmnt02 Jul 12, 2018
98211ac
unused state
fragmnt02 Jul 12, 2018
ccf7d6d
fix
fragmnt02 Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
REACT_APP_API_KEY=iSAbLNTnHlhG33VP27yEQDITzhxAZ1iZ
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend that you add this file to your .gitignore as this are api keys

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thnks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thnks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You pushed it? I can still see your .env config

REACT_APP_TIMEOUT=15000
REACT_APP_API_URL=https://api.giphy.com/v1/gifs/
Loading