lib: implement a superior workaround for the watchonly wallet on Windows #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the added comment for the details. No need to store the watchonly wallet under bitcoind's datadir anymore. 🎉 🎉
darosior
force-pushed
the
2308_fix_paths_on_windows
branch
from
2ed468e
to
0d15edf
Compare
darosior
force-pushed
the
2308_fix_paths_on_windows
branch
from
0d15edf
to
c727c07
Compare
We used to store it there, if it's not within our own datadir copy it from where it would have been stored by Liana v1. Note we don't conditionally compile this on Windows so the codepath can be tested with a functional test.
darosior
force-pushed
the
2308_fix_paths_on_windows
branch
from
c727c07
to
5680ad2
Compare
|
ACK 5680ad2 -- tested it on Windows Could use another ACK double checking i haven't missed any edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added comment for the details. No need to store the watchonly wallet under bitcoind's datadir anymore. 🎉 🎉
I've noticed this while working on fixing #630 on Windows which failed for the same root reason as why the watchonly wallet path didn't work on Windows.
Fixes #653.