Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bitcoind_started info in Gui app state #647

Closed
wants to merge 1 commit into from
Closed

Handle bitcoind_started info in Gui app state #647

wants to merge 1 commit into from

Conversation

edouardparis
Copy link
Member

  • Store in app state if bitcoind was started by gui
  • Forbid edit of bitcoind addr and port in settings if started by the gui.

@darosior
Copy link
Member

Forbid edit of bitcoind addr and port in settings if started by the gui.

Good call.

@edouardparis edouardparis force-pushed the forbid-edit-of-bitcoind-port-if-started-by-gui branch from 61b187b to 2df8797 Compare August 29, 2023 16:32
@edouardparis
Handle bitcoind_started info in Gui app state
04d78b1 
- Store in app state if bitcoind was started by gui
- Forbid edit of bitcoind addr and port in settings
  if started by the gui.
@edouardparis edouardparis force-pushed the forbid-edit-of-bitcoind-port-if-started-by-gui branch from 2df8797 to 04d78b1 Compare August 30, 2023 08:46
@edouardparis
Copy link
Member Author

I think we should use instead the field start_internal_bitcoind that will replace the 'bitcoind_config_exe'

@darosior
Copy link
Member

I concur. In the settings right?

@edouardparis
Copy link
Member Author

Deprecated in favor of #657

@edouardparis edouardparis deleted the forbid-edit-of-bitcoind-port-if-started-by-gui branch August 31, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edouardparis @darosior