bitcoind: fix the detection of unconfirmed RBF spending txs #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we walk through the spend transactions in the wallet, we may return the txid of the transaction that was replaced instead of the new one.
darosior
force-pushed
the
2308_fix_rbfd_spending_detection
branch
from
e722480
to
421c1af
Compare
|
Rebased after #628. |
|
ACK 421c1af -- tested it locally by running the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we walk through the spend transactions in the wallet, we may return the txid of the transaction that was replaced instead of the new one.
Note: this fixes the
test_conflicting_unconfirmed_spend_txsflakiness, which exposed this bug.