Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gui internal daemon: stop gracefully #624

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

edouardparis
Copy link
Member

No description provided.

@edouardparis edouardparis force-pushed the fix-gui-daemon-shutdown branch 2 times, most recently from 5c444aa to 04909df Compare August 22, 2023 13:21
gui/src/daemon/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -10,22 +9,13 @@ use liana::{

pub struct EmbeddedDaemon {
config: Config,
handle: Option<RwLock<DaemonHandle>>,
handle: DaemonHandle,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neaaat.

@darosior darosior mentioned this pull request Aug 22, 2023
4 tasks
@darosior
Copy link
Member

Let's merge #625 before you make this point to master?

@edouardparis edouardparis marked this pull request as ready for review August 22, 2023 14:20
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a1c7166

@darosior darosior merged commit 76dcc8b into wizardsardine:master Aug 22, 2023
18 checks passed
@edouardparis edouardparis deleted the fix-gui-daemon-shutdown branch August 22, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants