Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport for v7: gui: add help text for electrum address #1345

Merged
merged 1 commit into from
Sep 16, 2024
Merged

backport for v7: gui: add help text for electrum address #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion gui/src/app/view/settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ use crate::{
view::{hw, warning::warn},
},
hw::HardwareWallet,
node::bitcoind::{RpcAuthType, RpcAuthValues},
node::{
bitcoind::{RpcAuthType, RpcAuthValues},
electrum,
},
};

pub fn list(cache: &Cache, is_remote_backend: bool) -> Element<Message> {
Expand Down Expand Up @@ -591,6 +594,7 @@ pub fn electrum_edit<'a>(
.size(P1_SIZE)
.padding(5),
)
.push(text(electrum::ADDRESS_NOTES).size(P2_SIZE))
.spacing(5),
);

Expand Down
1 change: 1 addition & 0 deletions gui/src/installer/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,6 +1382,7 @@ pub fn define_electrum<'a>(address: &form::Value<String>) -> Element<'a, Message
.size(text::P1_SIZE)
.padding(10),
)
.push(text(electrum::ADDRESS_NOTES).size(text::P2_SIZE))
.spacing(10);

Column::new().push(col_address).spacing(50).into()
Expand Down
4 changes: 4 additions & 0 deletions gui/src/node/electrum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ pub enum ConfigField {
Address,
}

pub const ADDRESS_NOTES: &str = "Note: include \"ssl://\" as a prefix \
for SSL connections. Be aware that self-signed \
SSL certificates are currently not supported.";

impl fmt::Display for ConfigField {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
match self {
Expand Down
Loading