Prepare liana v7.0 release #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
reviewed
Sep 12, 2024
|
|
||
| - We check that the change multipath is not hardened while importing descriptor in LianaDescriptor | ||
| wrapper. | ||
| - We add the minimum feerate requested in the error message of the create spend command. |
There was a problem hiding this comment.
I'm not sure to understand, did we add the requested feerate, or the minimum feerate?
|
(I only commented about what was present and haven't been through the git history to check nothing was missing.) |
edouardparis
force-pushed
the
prepare-liana-v7.0-release
branch
from
2810b1c
to
d95e792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.