Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui(settings): fix daemon reload handling for electrum #1320

Merged

Conversation

jp1ac4
Copy link
Collaborator

@jp1ac4 jp1ac4 commented Sep 11, 2024

In case of error reloading daemon for Electrum, set edited to false (same handling as for bitcoind).

@darosior
Copy link
Member

tested ACK ff3d497. Not bulletproof as i need to get back to the settings and re-click save with the previous settings for the daemon to be restarted, but still helps a lot to have the previous-working-config ready to be saved.

@darosior darosior merged commit f6baec3 into wizardsardine:master Sep 11, 2024
30 of 31 checks passed
@jp1ac4 jp1ac4 deleted the gui-settings-daemon-reload-electrum branch September 11, 2024 10:42
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants