Merge #612: bitcoind: Make BitcoinD public and add stop method

3372a8d bitcoind: add `stop` method (jp1ac4)
60ee667 bitcoind: make `BitcoinD` public (jp1ac4)

Pull request description:

  This is needed as part of #592 for both checking connectivity to the internal `bitcoind` and stopping it when closing Liana.

ACKs for top commit:
  darosior:
    utACK 3372a8d

Tree-SHA512: 804cf6a94688db7aa8d78b10a47d08f58ff93c322c9f91bee7b98625d7d5e0633282fa4d0a1b801e56a334a4448f0348930fe5ef3265b5719bd090b6128fc67a

src/bitcoin/d/mod.rs

@@ -1096,6 +1096,11 @@ impl BitcoinD {
  }
  }
  }
+
+ /// Stop bitcoind.
+ pub fn stop(&self) {
+ self.make_node_request("stop", &[]);
+ }
 }
 
 /// An entry in the 'listdescriptors' result.

src/lib.rs

@@ -15,11 +15,11 @@ mod testutils;
 pub use bip39;
 pub use miniscript;
 
-pub use crate::bitcoin::d::{BitcoindError, WalletError};
+pub use crate::bitcoin::d::{BitcoinD, BitcoindError, WalletError};
 #[cfg(feature = "daemon")]
 use crate::jsonrpc::server::{rpcserver_loop, rpcserver_setup};
 use crate::{
- bitcoin::{d::BitcoinD, poller, BitcoinInterface},
+ bitcoin::{poller, BitcoinInterface},
  config::Config,
  database::{
  sqlite::{FreshDbOptions, SqliteDb, SqliteDbError},