[PG-621] - fix play button disappears from video #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit edefb09.
This reverts commit 2c2c759.
* Revert "fix scroll indicator (#996)" This reverts commit ca84f2b. * Revert "refactor new sps in the gallery package (#985)" This reverts commit edefb09. * Revert "≈Revert "scrollDirection in gallery files"" This reverts commit a8fe658. * Revert "scrollDirection in gallery files" This reverts commit 9d75fb9. * Revert "Sp playground settings (#970)" This reverts commit 7f810ef. * Revert "remove only in lib tests (#974)" This reverts commit 8aef18d. * Revert "refactor layoutHelper to new styles (#969)" This reverts commit 6c2ed7b. * Revert "add files for all the layouts (#968)" This reverts commit 28ce46d. * Revert "add new galleryLayout in presets (#967)" This reverts commit 734617b. * Revert "add new cosnts for all v4 defaults (#966)" This reverts commit 983fb16. * Revert "fix const for new scrollDirection (#965)" This reverts commit 0eda8c6. * Revert "add flat styles in convertion (#964)" This reverts commit be4c11a. * Revert "Sp styling params (#963)" This reverts commit 85fd6d2. * Revert "Sp behaviour params gallery horizontal (#962)" This reverts commit 1f4f728. * Revert "Sp behaviour params gallery vertical (#961)" This reverts commit d967102. * Revert "Sp behaviour params item (#960)" This reverts commit a8948ae. * Revert "files for layoutParams_targetItemSize (#959)" This reverts commit a1345f8. * Revert "add files for layoutParams_info (#958)" This reverts commit a0c35c8. * Revert "create files for layoutPArams_navigationArrows (#957)" This reverts commit 9ebdc16. * Revert "create files for layoutPArams_thumbnails (#956)" This reverts commit c82fa6b. * Revert "create files for layoutParams_structure (#955)" This reverts commit a7bafd4. * Revert "create files for layoutParams_crop (#954)" This reverts commit 13c438f. * Revert "add groups new sp files (#953)" This reverts commit de818fe. * Revert "export flat default options (#944)" This reverts commit 5d89649. * dummy commit * Revert "dummy commit" This reverts commit 299a333. * arrows * export
* move onclick to item container * delete unneccery onKeyDown
* fix invalid ARIA role attribute on v4 * change 'itemClick' test to match the new role change * Store the result of this.getItemAriaRole() in a constant
…lement (#1256) * adding disable focus ring prop
… smaller than the current activeIndex (#1259)
* wip - ensure the correct video player is loaded * revert change * insert to try
* remove hls dynamic import - temporary * add auto playVideo import * move to componentWillMount
* get correct galleryStructure to calculate gallery width * refresh arraow visibility - container dependent * get the correct props on removeArrow functions
* fix highlighted thumbnail calc * show all relevant thumbnails according to the cur activeIndex
* update deps and node version and fix jest config * bump ts-node * playground jsdom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showing play button on the video item placeholder only depends on showVideoPlayButton prop and not on the loading status of the video.