Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - image / container border pushes image instead of it resizing automaticly #1179

Closed
wants to merge 2 commits into from

Conversation

liatv
Copy link
Contributor

@liatv liatv commented Dec 23, 2023

Fix - https://wix.monday.com/boards/4776391986/pulses/5238889014

Removing const image size and settings box-sizing:border-box attribute at the image container so it can be responsive to border changes

before -
image

after -
image

@liatv liatv requested a review from yhattav December 23, 2023 22:27
@yhattav
Copy link
Collaborator

yhattav commented Dec 24, 2023

Hey,
I understand the request here.
But, how does this work with the overlay? Why didnt you show it on the after image?
We use the layout's image size to make text layouting calculations in the overlay. if those are shortened by pure css, the calculations will go wrong.
We can make product decisions, but only after knowing that.

Again, not a bug, product decisions are needed - but you must present all the implications of this change. (also, only in v5, maybe in a minor)

@liatv liatv closed this Dec 24, 2023
@liatv
Copy link
Contributor Author

liatv commented Dec 24, 2023

This issue needs to be solve be either changing CSS on Wix side or adding border to settings on native

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants