Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isRelevant for taregtItemSize #1106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix isRelevant for taregtItemSize #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/lib/src/settings/options/layoutParams_targetItemSize_value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import { default as GALLERY_CONSTS } from '../../common/constants';
import optionsMap from '../../core/helpers/optionsMap';

export default {
title: 'Item Size (smart)',
description: `Set the item size between 1 to 100 units. The real size will be determined by the layout.`,
isRelevant: () => {
return true;
isRelevant: (options) => {
return (
options[optionsMap.layoutParams.structure.scrollDirection] ===
GALLERY_CONSTS[optionsMap.layoutParams.structure.scrollDirection].VERTICAL
);
},
isRelevantDescription:
'Set a Horizontal gallery ("Scroll Direction" as "Horizontal") and set Responsive Type to Fit to screen',
'Set a VERTICAL gallery ("Scroll Direction" as "Vertical") and set Responsive Type to Fit to screen',
default: 30,
};