2.1.x/trustlessness #446
Open
2.1.x/trustlessness #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidiaz
force-pushed
the
2.1.x/trustlessness
branch
from
b521ff3
to
e8f8ba4
Compare
…ss implementations
This was referenced Oct 31, 2024
Tommytrg
reviewed
Nov 21, 2024
|
|
||
| import "./WitFeeds.sol"; | ||
| import "./interfaces/IWitPriceFeeds.sol"; | ||
|
|
||
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Witnet Oracle blockchain. | ||
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Wit/oracle blockchain. |
There was a problem hiding this comment.
Suggested change
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Wit/oracle blockchain. | |
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Wit/Oracle blockchain. |
Tommytrg
reviewed
Nov 21, 2024
|
|
||
| import "../patterns/Ownable2Step.sol"; | ||
|
|
||
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Wit/oracle blockchain. |
There was a problem hiding this comment.
Suggested change
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Wit/oracle blockchain. | |
| /// @title WitPriceFeeds: Price Feeds live repository reliant on the Wit/Oracle blockchain. |
Tommytrg
reviewed
Nov 21, 2024
| /// @dev - invalid SLA parameters were provided; | ||
| function getQueryStatusBatch(Witnet.QueryId[] calldata) external view returns (Witnet.QueryStatus[] memory); | ||
|
|
||
| /// @notice Request real world data from the Wit/oracle sidechain. |
There was a problem hiding this comment.
We should replace all Wit/oracle with Wit/Oracle
Suggested change
| /// @notice Request real world data from the Wit/oracle sidechain. | |
| /// @notice Request real world data from the Wit/Oracle sidechain. |
| ); | ||
| } | ||
|
|
||
| // WIP ... |
There was a problem hiding this comment.
What is missing here? Do we need more methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #444 #445.