Re-try #2135
Re-try #2135
Conversation
|
@mxstbr just pushed some changes ready for review (ignore some eslint cleanup like removing unused model functions)... One problem we had was that we weren't returning from a promise which might have been throwing errors. Also: in our current authentication implementation we are mixing callbacks and promises, warned against by eslint and more info here: https://spin.atomicobject.com/2017/04/06/nodejs-promises-callbacks/ - does that look like something we should fix now? |
| }) | ||
| .catch(err => { | ||
| done(err); | ||
| return null; |
There was a problem hiding this comment.
I've fixed this on the #2096 branch too, but I did
return getUser({ id })
.then(user => {
done(null, user);
return user;
})Unsure if that makes any difference tho.
Lollll I wish Passport would have a Promise interface Alas, it doesn't, so no way around that. jaredhanson/passport#536 |
Needs more testing...