Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebars 👻 #9890

Draft
wants to merge 51 commits into
base: 5.0.0-beta
Choose a base branch
from
Draft

Sidebars 👻 #9890

wants to merge 51 commits into from

Conversation

delucis
Copy link
Member

@delucis delucis commented Oct 30, 2024 •
edited
Loading

Description (required)

Updates the docs sidebar to use custom category tabs component and refactors how we manage sidebar configuration and translation.

To-do

  • Add custom “current page” highlighting for pages not in the sidebar (tutorial chapters, error messages)
  • Fix collapse persistence behaviour for sidebar groups

@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →

Name Link
🔨 Latest commit 7b345d1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6739e5e3bb061200088f80f4

@delucis delucis added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Oct 31, 2024
@HiDeoo HiDeoo mentioned this pull request Oct 31, 2024
Merged
@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! 🚨 action labels Nov 13, 2024
@github-actions github-actions bot removed i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! 🚨 action labels Nov 13, 2024
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 14, 2024
delucis and others added 21 commits November 14, 2024 17:09
@delucis
Add some comments to the sidebar config
d49e849
@delucis
Move bcp normalization utility to utils directory
6f57234
@delucis
Move languages config list up out of i18n/
c74bfe7
@delucis
Move path utilities to src/util/ directory
475bc19
@delucis
Move cached fetch utility to src/util/ directory
e153737
@delucis
Delete some ancient cruft
7d8ffd0
@delucis
Move Lunaria files into scripts/ directory
1d7f3c2
@delucis
Add type utility for navigation dictionaries and add placeholders for…
bec16d4 
… other languages
@delucis
Move plugins and integrations under config/ directory
a6b9abe
@delucis
Organize imports in astro config
a1cf10d
@delucis
Watch ./config/* directory for file changes in dev
5d9b923
@delucis
Delete netlify.toml (NODE_OPTIONS and build command set in the UI)
616db70
@delucis
Remove error messages from sidebar
cafca93
@delucis
Sneaky sentence case
babee9e
@delucis
Associate tutorial and error message pages with their parents in the …
3aea2ab 
…sidebar
@delucis
Improve comment
c1995dc
@delucis
Refactor sidebar marking function to be synchronous and avoid `getEnt…
d92ae7b 
…ry()`
@delucis
Update GitHub labelling config for new i18n file layout
5048853
@delucis
Fix bug in sidebar tab ID generation
ec61b2f
@delucis
Top level config reference
97c75e1
@sarah11918
reorder reference sidebar content because so many top-level entries now
3f522b2
@sarah11918 sarah11918 mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.0.0-beta glossary Community initiative to build an Astro glossary! i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucis @sarah11918