feat(next): routes resolved hook

[florian-lefebvre]

Description (required)

withastro/astro#12329

Related issues & labels (optional)

• Closes #
• Suggested label:

[netlify]

✅ Deploy Preview for astro-docs-2 ready!

Name	Link
🔨 Latest commit	c3d1215
🔍 Latest deploy log	https://app.netlify.com/sites/astro-docs-2/deploys/6740ae4cf4bb170008900f78
😎 Deploy Preview	https://deploy-preview-10077--astro-docs-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[astrobot-houston]

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
en/guides/upgrade-to/v5.mdx	Source changed, localizations will be marked as outdated.
en/reference/integrations-reference.mdx	Source changed, localizations will be marked as outdated.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

[sarah11918]

Looks great @florian-lefebvre ! Just need to phrase this more like a "What should I do?" so I made a basic model, but you should update as necessary!

[sarah11918]

Oh, and are we documenting this on the Integrations API page too? Is that coming later?

[florian-lefebvre]

There you go 😄

[sarah11918]

Some minor edits and suggestions below! We'll get this wrapped up well in time for a release tomorrow, no worries!

[sarah11918]

Suggested change

	* The current **pattern** of the route. For example:
	* The current **pattern** of the route, the path relative to the `src/pages/` directory and without a file extension. For example:

This appears to be the pattern, right? Would you change this description?

[florian-lefebvre]

All those jsdoc come directly from core, and are also in astro:build:done. So do you prefer not to update the jsdoc on that page at all, or update them in core and then reflect the changes here?

[sarah11918]

Ah, OK. How important is it that these are kept identical to core? This is public facing docs, and one could argue should be written like docs.

(I was even thinking, this is a LOT of documenting going on inside a code sample. Why aren't we writing normal docs here?)

In that case, I'm OK to merge exactly what's already matching, but then think about at some point in the future this page becomes an actual docs page, not just copy paste of whatever you've written in code that I have no control over the quality of. 😅

[florian-lefebvre]

Yeah I think that's a good idea 👍

[sarah11918]

@florian-lefebvre

See my comment about being OK to copy these as-is since this is apparently just a reproduction of what's in code.

BUT, these don't feel like the best docs to me. (Why is docs just a copy of code comments and not "documentation"?) We can leave that for some potential future exploration, whether this page needs itself an overhaul! And we don't have to block merging for the feature!

[florian-lefebvre]

I think we can still take care of #10077 (comment) in this one tho!

[sarah11918]

Sure! Can you propose an example that would go there?

[florian-lefebvre]

@sarah11918 i tried to add a little example, let me know what you think!

[sarah11918]

Just left the tiniest suggestion, but good to go whenever you're happy with it! (And, we can think about whether we want to improve this page overall in future!) 🚀