ci: set changeset base remote

[ascorbic]

Changes

This should prevent the issues when reolving the base branch

Testing

Testing gh actions? lol

Docs

[changeset-bot]

⚠️ No Changeset found

Latest commit: b433e44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ascorbic]

!preview changeset base

[github-actions]

Invalid command. Expected: "/preview "

[ascorbic]

!preview changeset-base

[bluwy]

I believe the baseBranch field is only used to infer suggested changed packages when you run pnpm changeset, not related to publishing (if that's what you're trying to fix)

[ascorbic]

It was having trouble because next wasn't checked-out locally. This seemed to fix that, but is now complaining about being in pre mode, so I've added a line to exit it.

[bluwy]

It was having trouble because next wasn't checked-out locally. This seemed to fix that

Basing on origin assumes that the remote is named origin I think, so it wouldn't work if some had a different remote name? e.g. from forks. I think I'd still leave it as next. I've also sent a fix in @changesets/cli recently that doesn't hard error if the baseBranch is not found though, but we haven't updated it yet.

About exiting pre, that seems fine to me 👍 We need to make sure that we remove it before merging next to main, or make it robust that it doesn't exit 1 if we're already out of pre mmode though.

[ascorbic]

Ah great, I didn't realise you had a fix. I did the PR against main already, with || true #12502

[ascorbic]

@bluwy https://github.com/withastro/astro/actions/runs/11971557314/job/33376631695 😢

[bluwy]

Maybe we need to update this line

astro/.github/workflows/snapshot-release.yml

Line 66 in 3dc714a

- run: git fetch origin main:main

[github-actions]

Invalid command. Expected: "/preview "

[ascorbic]

Isn't that the same issue as setting baseBranch? Maybe we should combine changing the baseBranch with adding git remote set-url origin ... to set the origin to this repo

[bluwy]

I don't think we should change the base branch with origin/ as it affects local development too. Maybe we can do that in CI only? Could use jq to set it. Or we can use jq to read it and then git fetch the right branch

[ascorbic]

Yeah, or maybe get the base branch for the PR?

[bluwy]

Could work too, but I'm not really sure what would happen if the base branch is a feature branch.

[ascorbic]

So it looks ike the downside to exiting pre mode is that it publishes everything! https://github.com/withastro/astro/actions/runs/11971962174/job/33377860028

[bluwy]

Yeah I don't think we could workaround that since that's kinda how changesets work. Previously even if we're not in pre mode, and the base branch had existing unrelated changesets, it also triggers releases from those changesets. So it's usually publishing more than it's needed.