-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support new location for content config #12475
Conversation
🦋 Changeset detectedLatest commit: c70d181 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e3f859b
to
0c06031
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of the PR is a bit vague. Here's some questions/concerns regarding the changes:
- we are still supporting the old content collections in it, should we disallow this?
- what's the plan of the old file?
- is it possible to use the same logic we use to load known files in Astor?
.changeset/thirty-clocks-jump.md
Outdated
|
||
Changes the default content config location from `src/content/config.*` to `src/content.config.*`. | ||
|
||
The previous location is still supported, but the new location is now preferred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the plan for the previous one? Is it deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ascorbic should update the changeset, and mention that the new config doesn't old content collections? (At least, that's what I understood from one of your comments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, updated to say that the old location is still supported, and is required for legacy mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
893accf
to
bd39e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things that I couldn't understand:
- is
content/config.ts
considered deprecated? - is there a plan for the "old" configuration file? If so, which one is it?
Code wise it looks good though
.changeset/thirty-clocks-jump.md
Outdated
|
||
Changes the default content config location from `src/content/config.*` to `src/content.config.*`. | ||
|
||
The previous location is still supported, but the new location is now preferred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ascorbic should update the changeset, and mention that the new config doesn't old content collections? (At least, that's what I understood from one of your comments).
you aren't needed lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
Changes
Adds support for content config files in
src/content.config.*
. This means there no longer needs to be asrc/content
folder.Fixes PLT-2649
Testing
Config files moved for most fixtures, though with some legacy collections kept in the old location to ensure test coverage.
Docs
Docs will need updating with the new location, as eventually will templates etc.