workaround prerender in pageMap

[alexanderniebuhr]

we need to plugins so we can use generateBundle twice. Any other hook doesn't have file names with hashes already, and using writeBundle would need fs operation, which I think is worse.

regex is scary, but I'm not sure if it is worth to create an ast and convert back to string again

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9277080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Fryuni]

I don't get why this can't be done with a single plugin. Can't you do one loop after the other in the same plugin?

[alexanderniebuhr]

@Fryuni Updated the logic, now the regexp should be much safer. wdyt?

[bluwy]

If this workarounds some issue with pre-rendering currently, then the code seems fine to me. But I think given the workarounds needed so far, we should prioritize making prerendering more robust in Astro core.

[Fryuni]

Seems good now. Well, as good as a workaround using regex can be 😅

If this workarounds some issue with pre-rendering currently, then the code seems fine to me. But I think given the workarounds needed so far, we should prioritize making prerendering more robust in Astro core.

Pre-rendering itself is not a problem. The fact that Astro builds a single bundle for pre-rendering and server rendering and considers the other as (hopefully) unreachable code is the problem. If you have a single server route, you need to upload the code to generate all your routes, which can hit the target platform's source size limits.

This was noticed first on Cloudflare because it has the smallest limit for the free tier, but Vercel, Netlify, and others are also subject to this problem if you have a big enough project.

[alexanderniebuhr]

@Fryuni @bluwy Both of you are right. This is not really a prerendering issue in it's core, but we have discovered other issues which are also caused by prerendering behavior. So prioritizing this in core makes total sense to me.