1.21.2 Port #324
1.21.2 Port #324
Conversation
|
mfw superseding your own PR |
|
Yea, old one had some cring in it that was needing to be redone after finding out better methods to do some things |
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.function.Consumer; | ||
| import java.util.function.Function; | ||
|
|
||
| public class NinePatchTexture { |
There was a problem hiding this comment.
honestly, is it even worth to keep this class? doesn't Minecraft have native nine-patched textures now?
There was a problem hiding this comment.
Frankly don't think it functions the same way and really up to glisco to decided
src/main/java/io/wispforest/owo/mixin/shader/ShaderProgramAccessor.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Due to changes within 1.21.2 makes {@link AutoRegistryContainer} impossible due to requiring | ||
| * the {@link net.minecraft.registry.RegistryKey} leading to the need to supplier the key before | ||
| * fully creating the desired entry. | ||
| * </br></br> | ||
| * Recommend using Minecraft methods for registering such entry | ||
| */ | ||
| @Deprecated(forRemoval = true) | ||
| public interface BlockRegistryContainer /*extends AutoRegistryContainer<Block>*/ { |
There was a problem hiding this comment.
if you're removing all methods and making the interface basically useless why not just remove it?
in any case imo this and the item registry container should be able to be saved if they're changed to work more like in the field registration adjustments pr
There was a problem hiding this comment.
Done such as a way to illustrate why it was removed, can be removed if such is not desired but find this more helpful than just removing outright
| /** | ||
| * Due to changes within 1.21.2 makes {@link AutoRegistryContainer} impossible due to requiring | ||
| * the {@link net.minecraft.registry.RegistryKey} leading to the need to supplier the key before | ||
| * fully creating the desired entry. | ||
| * </br></br> | ||
| * Recommend using Minecraft methods for registering such entry | ||
| */ |
There was a problem hiding this comment.
same as for BlockRegistryContainer
| /** | ||
| * Due to changes within 1.21.2 makes {@link AutoRegistryContainer} impossible due to requiring | ||
| * the {@link net.minecraft.registry.RegistryKey} leading to the need to supplier the key before | ||
| * fully creating the desired entry. | ||
| * </br></br> | ||
| * Recommend using Minecraft methods for registering such entry | ||
| */ | ||
| @Deprecated(forRemoval = true) |
There was a problem hiding this comment.
same as for BlockRegistryContainer
…mponent, compile against 1.21.2 proper
Supersedes #321
Contains breaking changes for various aspects of API:
Breaking Changes:
AutoRegistryContainerhas been deprecated for Item, Block, and EntityType due to the changes within Minecraft that make it quite uselessOther Changes:
I believe
OwoUIDrawContextshould change to allow for passing the Function to create RenderLayer to be similar toDrawContextso overall this will be marked as a draft for the time being