vec3i serialization #187
Merged
vec3i serialization #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that it
gliscowo
requested changes
Oct 30, 2023
| * @return The deserialized vector | ||
| */ | ||
| public static Vector3f readi(PacketByteBuf buffer) { | ||
| return new Vector3f(buffer.readInt(), buffer.readInt(), buffer.readInt()); |
There was a problem hiding this comment.
Not the greatest idea to read integers from a buffer you've written floats to. Also like, don't write floats :poggus:
| */ | ||
| public static NbtCompound puti(NbtCompound nbt, String key, Vec3i vec3i) { | ||
|
|
||
| NbtList vectorArray = new NbtList(); |
There was a problem hiding this comment.
When serializing an array of integers, use an NbtIntArray
gliscowo
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that it