Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple owo-ui windows #161

Closed

Conversation

BasiqueEvangelist
Copy link
Contributor

@BasiqueEvangelist BasiqueEvangelist commented Aug 4, 2023

Adds support for opening windows from the main Minecraft window through the OwoWindow class (and the more bare bones FramebufferWindow class).

Changes

  • FramebufferWindow allows creating a low-level separate window, with rendering fully managed by the user
  • OwoWindow creates a window with an owo-ui component as the root, managing events and registering itself itself
  • WindowContext/CurrentWindowContext allow detecting the current window and registering per-window features (which is useful for UI components that create window-sized framebuffers or screens)

@BasiqueEvangelist BasiqueEvangelist marked this pull request as ready for review August 5, 2023 14:44
@BasiqueEvangelist BasiqueEvangelist changed the base branch from 1.20 to 1.20.2 October 4, 2023 20:40
@BasiqueEvangelist
Copy link
Contributor Author

on 1.20.2 now

@BasiqueEvangelist BasiqueEvangelist deleted the multiple-windows branch October 6, 2023 21:48
@Minenash
Copy link

Why was this closed?

@BasiqueEvangelist
Copy link
Contributor Author

Why was this closed?

I didn't want to continue maintaining a PR that didn't get any feedback after 1 month

@Minenash
Copy link

Yeah, that's fair. But damn, been looking forward to it since it was mentioned you were working on it

@BasiqueEvangelist
Copy link
Contributor Author

Yeah, that's fair. But damn, been looking forward to it since it was mentioned you were working on it

I can try to extract it into a separate library if you want to play around with it.
I will have to mixin into owo for that to work, though.

@BasiqueEvangelist
Copy link
Contributor Author

Also, like, if there's any indication that this will be actually looked at (so that I won't have to bump the PR 6 times) I'll reopen this PR

@Minenash
Copy link

Minenash commented Oct 22, 2023

Yeah, if owo doesn't end up having it, then that would be awesome ❤️

@BasiqueEvangelist BasiqueEvangelist restored the multiple-windows branch October 23, 2023 16:19
@BasiqueEvangelist
Copy link
Contributor Author

fuck it

@BasiqueEvangelist BasiqueEvangelist changed the base branch from 1.20.2 to 1.20.3 December 14, 2023 12:46
@BasiqueEvangelist BasiqueEvangelist changed the base branch from 1.20.3 to 1.21 June 30, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants