Rework of Weather UI #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Hushous
commented
Sep 30, 2024
Hushous
commented
- Redesigned the UI of the weather module
- Bigger Map
- streamlined infobox
- full translation
- removed unnecessary code segments
- reduce redundant lines - clean html - rework UI
not done yet, translation code filterOption.key doesnt get recognized
Added dynamic translation
-translation for tags -injected translateservice in .ts script
api states name and state now together in station.name
switch progress
- download button anchored to bottom - bulma calendar in place (on 1920x1080) - deleted tags
- reduce codebase - increase readability - reorder functions
- added tags for information - deleted unnecessary translations - added date representation for selected dates
- dates get compared in unix timestamp
- deleted download disable function
cptpiepmatz
requested changes
Oct 2, 2024
| <div class="dropdown is-hoverable is-fullwidth"> | ||
| <div class="dropdown-trigger"> | ||
| <button class="button"> | ||
| <span>{{ "weather-data.attributes." + type.key | translate }}</span> |
There was a problem hiding this comment.
Please add some chevron (e.g. <ion-icon name="chevron-down-outline"></ion-icon>), similar to this example https://bulma.io/documentation/components/dropdown/
| @@ -304,7 +410,6 @@ export class WeatherDataComponent implements OnInit { | |||
| console.info("Start downloading!"); | |||
|
|
|||
| this.weatherService.fetchWeatherDataByStation(url.toString()).subscribe({ | |||
There was a problem hiding this comment.
You have a single value, use a Promise instead
| * @param timestamp to be converted | ||
| * @returns time in seconds (unix timestamp) | ||
| */ | ||
| convertDateStringToUnixTime(dateString: string): number { |
There was a problem hiding this comment.
You can format dates via formatDate and DatePipe
add json postfix Co-authored-by: Piepmatz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.