General clarification in syntax description and README #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvid
requested changes
Jun 15, 2024
martinrieder
changed the title
scale and fixedsize.
martinrieder
changed the title
|
@kvid it may have been a bad idea to recycle this PR to suggest other changes to the syntax description. Since the review still lists a requested change, it remains blocked for merging. Could you please review this again or do you want me to put the commits into a new PR? |
Co-authored-by: kvid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Per the discussion below, I am not changing the image description to add missing attributes.
I am instead proposing some other clarification on the syntax description and alignment with README.