Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Graphviz error when hiding all pins #375

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

kvid
Copy link
Collaborator

@kvid kvid commented Jun 5, 2024

This bug was reported in #257 more than 2.5 years ago, but is still present in v0.4, and can be triggered by e.g. this YAML input:

connectors:
  X1:
    pincount: 2
    hide_disconnected_pins: true
connections:
 - - X1

Graphviz reports an error when the HTML table of pins is empty.

This minor change should fix #257

src/wireviz/Harness.py Show resolved Hide resolved
@formatc1702 formatc1702 merged commit 2f4fe11 into release/v0.4.1-rc Jun 14, 2024
4 checks passed
@formatc1702 formatc1702 deleted the fix257 branch June 14, 2024 13:18
@kvid kvid linked an issue Jun 22, 2024 that may be closed by this pull request
kvid added a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] hide_disconnected_pins when nothing is connected
3 participants