Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML template placeholders for filename #371

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

kvid
Copy link
Collaborator

@kvid kvid commented May 30, 2024

This will e.g. enable users to replace SVG diagram with PNG, that is needed as a work-around when the SVG output from Graphviz is not looking good. Suggested as work-around for Graphviz bug in #175 (comment)

  • <!-- %filename% -->
  • <!-- %filename_stem% -->
  • <!-- %diagram_png_b64% -->
  • The placeholders should be documented, maybe in a new templates/README.md.

@kvid kvid mentioned this pull request May 30, 2024
25 tasks
kvid added 3 commits May 31, 2024 22:08
This will e.g. enable users to replace the SVG diagram with PNG,
that is needed as a work-around when the SVG output from Graphviz
is not looking good. Suggested as work-around for Graphviz bug in
#175 (comment)
This will enable users to replace the SVG diagram with an embedded PNG,
that is an improved work-around when the SVG output from Graphviz
is not looking good. Suggested as work-around for Graphviz bug in
#175 (comment)
Add local replacement_if_used() that call function to read the file
only when needed and append the return value as replacement.
@kvid kvid marked this pull request as draft June 4, 2024 19:18
@kvid kvid force-pushed the release/v0.4.1-rc branch 2 times, most recently from db1e77f to ddb2cba Compare June 7, 2024 23:49
kvid added 2 commits June 9, 2024 23:59
Describe the HTML Output Templates, how they are specified,
and placeholder usage within these templates.
@kvid kvid marked this pull request as ready for review June 9, 2024 22:06
@formatc1702 formatc1702 merged commit 661f3cf into release/v0.4.1-rc Jun 11, 2024
4 checks passed
@formatc1702 formatc1702 deleted the fix175partially branch June 11, 2024 19:56
kvid added a commit that referenced this pull request Jun 12, 2024
This will e.g. enable users to replace the SVG diagram with PNG,
that is needed as a work-around when the SVG output from Graphviz
is not looking good. Suggested as work-around for Graphviz bug in
#175 (comment)
kvid added a commit that referenced this pull request Jun 12, 2024
This will enable users to replace the SVG diagram with an embedded PNG,
that is an improved work-around when the SVG output from Graphviz
is not looking good. Suggested as work-around for Graphviz bug in
#175 (comment)
kvid added a commit that referenced this pull request Jul 5, 2024
This will e.g. enable users to replace the SVG diagram with PNG,
that is needed as a work-around when the SVG output from Graphviz
is not looking good. Suggested as work-around for Graphviz bug in
#175 (comment)
kvid added a commit that referenced this pull request Jul 5, 2024
This will enable users to replace the SVG diagram with an embedded PNG,
that is an improved work-around when the SVG output from Graphviz
is not looking good. Suggested as work-around for Graphviz bug in
#175 (comment)
kvid added a commit that referenced this pull request Jul 5, 2024
Add local replacement_if_used() that call function to read the file
only when needed and append the return value as replacement.
kvid added a commit that referenced this pull request Jul 5, 2024
Describe the HTML Output Templates, how they are specified,
and placeholder usage within these templates.
kvid added a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants