feat: optionally use HTTPS (refs #60) #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogruis
reviewed
Oct 28, 2024
|
|
||
| @SpringBootTest | ||
| @EnableWireMock({@ConfigureWireMock(useHttps = true)}) | ||
| class HttpsTest { |
There was a problem hiding this comment.
I might be wrong but I thought you could have one wiremock instance with both http and https enabled. The current setup would force me to have two wiremock instances if I want to run on http and https at the same time.
Having to use
@EnableWireMock{{@ConfigureWireMock(port = 8081)}, @ConfigureWireMock(useHttps = true, port = 8082)}
I would prefer to use
@EnableWireMock(@ConfigureWireMock(useHttps = true, port = 8081, httpsPort = 8082)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.