-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to reload file descriptors at runtime. #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the one comment on the test, looks good
wm.stop(); | ||
} | ||
|
||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is still quite long and a bit hard to read.
Could you extract some methods to make it a bit more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
0db6471
to
397a19c
Compare
ef27f5c
to
ccab379
Compare
Allow file descriptors to be reloaded. Adds a method to GrpcHttpServerFactory to load the descriptors file currently in the blob store.
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java