Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to reload file descriptors at runtime. #87

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

RafeArnold
Copy link
Contributor

Allow file descriptors to be reloaded. Adds a method to GrpcHttpServerFactory to load the descriptors file currently in the blob store.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Copy link
Member

@tomakehurst tomakehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment on the test, looks good

wm.stop();
}

@Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is still quite long and a bit hard to read.

Could you extract some methods to make it a bit more descriptive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@RafeArnold RafeArnold force-pushed the reload-file-descriptors branch from 0db6471 to 397a19c Compare July 26, 2024 15:26
@RafeArnold RafeArnold force-pushed the reload-file-descriptors branch from ef27f5c to ccab379 Compare July 26, 2024 16:16
@RafeArnold RafeArnold merged commit 597ae69 into main Jul 29, 2024
9 checks passed
@RafeArnold RafeArnold deleted the reload-file-descriptors branch July 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants