Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map http status codes #103

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Map http status codes #103

merged 9 commits into from
Aug 23, 2024

Conversation

leeturner
Copy link
Collaborator

@leeturner leeturner commented Aug 23, 2024 •
edited
Loading

This PR maps the http error codes detailed in the official docs to their corresponding grpc status codes.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@leeturner
Add a mapping of http status codes to grpc status and message
b794e97
@leeturner
Handle the http status codes we are mapping
bd809e7 
If a response comes back with a http status code we are specifically
mapping, make sure we return a grpc error response with the correct
status and message
@leeturner
Rename the mappings variable to make it obvious it is for error statuses
f9b7d65
@leeturner
Handle the http error status codes we are mapping other than 404
0ae8096 
If a response comes back with a http status code we are specifically
mapping, make sure we set the status and message so this can be
returned in the onComplete method of the streaming client
@leeturner
Update the 404 grpc status and validate the error mappings
f0ec1a6 
We are now returning the recommended grpc status for 404 responses and
parameterised tests have been added to validate the mappings from http
error codes to grpc statuses
@leeturner
Update the 404 grpc status and validate the error mappings
bfa15bb 
We are now returning the recommended grpc status for 404 responses and
parameterised tests have been added to validate the mappings from http
error codes to grpc statuses
@leeturner
Run spotless
90d6635
@leeturner
Merge remote-tracking branch 'origin/main' into map-http-status-codes
28dfc76
@leeturner
Merge remote-tracking branch 'origin/main' into map-http-status-codes
e55ecf0
@leeturner leeturner merged commit 924363a into main Aug 23, 2024
8 checks passed
@leeturner leeturner deleted the map-http-status-codes branch August 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leeturner