add sftTokenSecret reference #725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
smatting
reviewed
Aug 19, 2024
bin/offline-secrets.sh
Outdated
| @@ -39,6 +39,8 @@ brig: | |||
| setNexmo: |- | |||
| key: "dummy" | |||
| secret: "dummy" | |||
| # Uncomment and update value to enable sft credentials provisioning | |||
There was a problem hiding this comment.
"Provisioning" is not correct, nothing is being provisioned
Maybe something like
Suggested change
| # Uncomment and update value to enable sft credentials provisioning | |
| # Uncomment to connect to SFT servers that require it``` |
smatting
reviewed
Aug 19, 2024
Comment on lines
25
to
26
| # Uncomment and update value to enable sft credentials provisioning | ||
| # sftTokenSecret: dummysecret |
smatting
reviewed
Aug 19, 2024
|
|
||
| # Uncomment for federation. Set values accordingly |
There was a problem hiding this comment.
Set values accordingly
Sounds to me like this sentence is saying nothing.
Or is it meant to say:
Use the same credentials as in and
?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-10302