Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate notification conversation timer update - WPB-11663 #2380

Open
wants to merge 2 commits into
base: refactor/generate-notification-conversation-member-leave
Choose a base branch
from

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Jan 13, 2025

TaskWPB-11663 [iOS] Generate UNNotificationContent for conversation timer update

Key points

This PR is about generating notification content related to timer update event (enabling/disabling self destructed messages) populating the right data in the notification (title, body, sound, category..).

Testing

  • Notification for timer update is correctly populated when the timer is enabled
  • Notification for timer update is correctly populated when the timer is disabled

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes/initiative: ios-sync-refactoring labels Jan 13, 2025
@jullianm jullianm requested a review from johnxnguyen January 13, 2025 10:19
@jullianm jullianm requested a review from netbe January 13, 2025 10:20
Copy link
Contributor

Test Results

    3 files      4 suites   4m 29s ⏱️
3 338 tests 3 310 ✅ 28 💤 0 ❌
3 348 runs  3 320 ✅ 28 💤 0 ❌

Results for commit 2cb70d1.

@datadog-wireapp
Copy link

Datadog Report

Branch report: refactor/generate-notification-conversation-timer-update
Commit report: d7d2dcb
Test service: wire-ios-mono

✅ 0 Failed, 3199 Passed, 28 Skipped, 2m 25.95s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant